Fix file descriptor leak when FileResponse raises an exception

2026-05-07 13:51:07 +02:00 · 2026-05-07 13:51:07 +02:00 · 4a6391730d
commit 4a6391730d
parent 4c4203f335
1 changed files with 8 additions and 3 deletions
--- a/photo21/views.py
+++ b/photo21/views.py
@ -23,9 +23,14 @@ class MediaAccess(View):
            raise Http404
        if not os.path.isfile(file_path):
            raise Http404
-        response = FileResponse(open(file_path, 'rb'))
-        response['Cache-Control'] = 'max-age=2678400'
-        return response
+        f = open(file_path, 'rb')
+        try:
+            response = FileResponse(f)
+            response['Cache-Control'] = 'max-age=2678400'
+            return response
+        except Exception:
+            f.close()
+            raise


 class IndexView(LoginRequiredMixin, ListView):