Add display name (first_name) shown instead of username on user-facing UI

photo21/forms.py

@@ -8,6 +8,12 @@ from django.utils.translation import gettext_lazy as _
 
 
 class CustomSignupForm(SignupForm):
+    first_name = forms.CharField(
+        label=_("Display name"),
+        max_length=150,
+        required=True,
+    )
+
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
@@ -16,6 +22,12 @@ class CustomSignupForm(SignupForm):
             "Please enter a valid email address ending with `@ens-rennes.fr`"
         )
 
+    def save(self, request):
+        user = super().save(request)
+        user.first_name = self.cleaned_data["first_name"]
+        user.save()
+        return user
+
     def clean_email(self):
         """
         Check that the email address ends with a trusted domain.

photo21/settings.py

@@ -290,6 +290,7 @@ ACCOUNT_EMAIL_VERIFICATION = config("EMAIL_VERIFICATION", default="mandatory")
 ACCOUNT_AUTHENTICATION_METHOD = "username_email"
 # ACCOUNT_LOGIN_METHODS = {'username', 'email'}
 ACCOUNT_FORMS = {"signup": "photo21.forms.CustomSignupForm"}
+ACCOUNT_USER_DISPLAY = lambda user: user.first_name or user.username
 
 if OAUTH_ENABLED:
     SOCIALACCOUNT_ONLY = OAUTH_ONLY

photo21/templates/base.html

@@ -132,7 +132,7 @@ SPDX-License-Identifier: GPL-3.0-or-later
     <footer>
         <p class="small text-center text-muted mt-1">
             {% if request.user.is_authenticated %}
-                {% trans "Connected as" %} <code>{{ request.user.username }}</code> &middot;
+                {% trans "Connected as" %} <code>{{ request.user.first_name|default:request.user.username }}</code> &middot;
             {% endif %}
             <a class="text-reset" href="https://git.sinfonie.org/sinfonie/photo26">{% trans "Source code" %}</a>
         </p>