sinfonie/photo26
1
0
Fork 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions

Fix file descriptor leak when FileResponse raises an exception

Browse source
This commit is contained in:
krek0 2026-05-07 13:51:07 +02:00
parent c15e9bf654
commit fdbf03800a
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
photo21/views.py
View file

@ -23,9 +23,14 @@ class MediaAccess(View):
raise Http404 raise Http404
if not os.path.isfile(file_path): if not os.path.isfile(file_path):
raise Http404 raise Http404
response = FileResponse(open(file_path, 'rb')) f = open(file_path, 'rb')
response['Cache-Control'] = 'max-age=2678400' try:
return response response = FileResponse(f)
response['Cache-Control'] = 'max-age=2678400'
return response
except Exception:
f.close()
raise
class IndexView(LoginRequiredMixin, ListView): class IndexView(LoginRequiredMixin, ListView):